jdaugherty commented on code in PR #15557:
URL: https://github.com/apache/grails-core/pull/15557#discussion_r3429097898
##########
.github/workflows/codeql.yml:
##########
@@ -69,26 +69,12 @@ jobs:
uses: github/codeql-action/init@7211b7c8077ea37d8641b6271f6a365a22a5fbfa
# v4.36.0
with:
languages: ${{ matrix.language }}
+ # The autobuild action runs `./gradlew testClasses`, which compiles
Groovy sample apps that are covered by regular CI.
Review Comment:
Don't we need to compile it? Isn't setting this to non not building for it?
##########
grails-bootstrap/src/main/groovy/org/grails/config/NavigableMap.groovy:
##########
@@ -21,11 +21,9 @@ package org.grails.config
import groovy.transform.CompileDynamic
import groovy.transform.CompileStatic
import groovy.transform.EqualsAndHashCode
+import groovy.util.logging.Slf4j
import org.codehaus.groovy.runtime.DefaultGroovyMethods
-import org.slf4j.Logger
Review Comment:
I thought we couldn't use slf4j in the bootstrap module, I assume a server
starts with these changes?
##########
grails-datastore-core/src/test/groovy/org/grails/datastore/mapping/reflect/ClassPropertyFetcherTests.groovy:
##########
@@ -114,8 +114,8 @@ class ClassPropertyFetcherTests {
}
}
-trait TestTrait<F extends Serializable> {
- F from
+trait TestTrait<T> {
Review Comment:
This code is still here but I thought @matrei opened a ticket and its been
fixed
##########
grails-gsp/core/src/test/groovy/org/grails/gsp/GspCompileStaticSpec.groovy:
##########
@@ -155,6 +164,7 @@ out.print(messageClosure('World'))
t.metaInfo.compilationException.message.contains('The variable
[somename] is undeclared.')
}
+ @IgnoreIf({ instance.isGroovy5OrLater() })
Review Comment:
PendingFeatureIf
##########
grails-data-graphql/core/src/main/groovy/org/grails/gorm/graphql/entity/dsl/helpers/Arguable.groovy:
##########
@@ -40,7 +40,16 @@ trait Arguable<T> extends ExecutesClosures {
List<CustomArgument> arguments = []
private void handleArgumentClosure(CustomArgument argument,
@DelegatesTo(strategy = Closure.DELEGATE_ONLY)Closure closure) {
- withDelegate(closure, (Object)argument)
+ // Inlined ExecutesClosures.withDelegate: Groovy 5 STC can't resolve a
parent trait's static method.
+ if (closure != null) {
Review Comment:
Isn't this fixed now so the inline is unnecessary?
##########
grails-gsp/core/src/test/groovy/org/grails/gsp/GspCompileStaticSpec.groovy:
##########
@@ -146,6 +153,8 @@ out.print(messageClosure('World'))
t.metaInfo.compilationException.message.contains('Cannot find matching
method java.util.Date#getTimeTypo()')
}
+ // GROOVY-12041: undeclared GSP variables are not reported through this
type-checking extension path on Groovy 5.
+ @IgnoreIf({ instance.isGroovy5OrLater() })
Review Comment:
This needs to be PendingFeatureIf; and we have ti have a ticket to track
fixing this later
##########
grails-data-graphql/core/src/main/groovy/org/grails/gorm/graphql/entity/dsl/helpers/ComplexTyped.groovy:
##########
@@ -131,7 +131,16 @@ trait ComplexTyped<T> extends ExecutesClosures {
private void handleField(@DelegatesTo(strategy =
Closure.DELEGATE_ONLY)Closure closure, Field field) {
field.nullable(defaultNull)
- withDelegate(closure, (Object)field)
+ // Inlined ExecutesClosures.withDelegate: Groovy 5 STC can't resolve a
parent trait's static method.
+ if (closure != null) {
Review Comment:
I thought this is fixed and the inline is unnecessary?
##########
grails-gsp/core/src/main/groovy/org/grails/gsp/compiler/GroovyPageTypeCheckingExtension.groovy:
##########
@@ -69,7 +69,24 @@ class GroovyPageTypeCheckingExtension extends
GroovyTypeCheckingExtensionSupport
}
methodNotFound { receiver, name, argList, argTypes, call ->
- if (isThisTheReceiver(call) || (call.objectExpression != null &&
currentScope.dynamicProperties.contains(call.objectExpression))) {
+ if (isThisTheReceiver(call)) {
Review Comment:
This issue is still not fixed, we should track this with a separate ticket
since it basically is removing the compile time check @paulk-asert I think this
was the issue you said was not looked at yet?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
