jdaugherty commented on code in PR #15746:
URL: https://github.com/apache/grails-core/pull/15746#discussion_r3433022373
##########
grails-shell-cli/src/main/groovy/org/grails/cli/profile/commands/CreateAppCommand.groovy:
##########
@@ -519,7 +519,7 @@ class CreateAppCommand extends ArgumentCompletingCommand
implements ProfileRepos
configuredRepositories.add(repository)
GrailsGradleRepository sitemeshSnapshots = new
GrailsGradleRepository(url:
'https://central.sonatype.com/repository/maven-snapshots', snapshotsOnly: true)
- sitemeshSnapshots.includeOnly('org[.]sitemesh.*', '.*',
'.*-SNAPSHOT')
+ sitemeshSnapshots.includeOnly('org[.]sitemesh.*', '.*', '.*')
Review Comment:
Same
comment, I don't think this needs to change
##########
grails-forge/grails-forge-core/src/main/java/org/grails/forge/build/gradle/GradleRepository.java:
##########
@@ -72,7 +72,7 @@ static Set<GradleRepository> getDefaultRepositories(String
grailsVersion) {
null,
List.of(
new VersionRegexRepoFilter(
- "org[.]sitemesh.*", ".*", ".*-SNAPSHOT"
+ "org[.]sitemesh.*", ".*", ".*"
Review Comment:
Is the M1 and actual release? I don't think this code should change since
the below filter will still filter to only snapshots
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
