jamesfredley commented on code in PR #15568:
URL: https://github.com/apache/grails-core/pull/15568#discussion_r3437707320
##########
grails-datastore-core/src/main/groovy/org/grails/datastore/mapping/core/connections/ConnectionSource.java:
##########
@@ -31,7 +31,14 @@ public interface ConnectionSource<T, S extends
ConnectionSourceSettings> extends
/**
* The name of the default connection source
*/
- String DEFAULT = "DEFAULT";
+ String DEFAULT = "default";
Review Comment:
Re-checked this against repo history and the final patch. The lowercase
default name is intentional: commit ad038d9a47 made `ConnectionSource.DEFAULT`
canonical as `"default"`, while `OLD_DEFAULT = "DEFAULT"` remains the legacy
compatibility alias. `HibernateDatastore.getDatastoreForConnection(...)`
accepts both values. I dropped the attempted reversal, so this PR no longer
changes the default datastore name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
