borinquenkid commented on code in PR #15568: URL: https://github.com/apache/grails-core/pull/15568#discussion_r3440345325
########## grails-data-hibernate7/core/src/main/groovy/grails/orm/CriteriaMethods.java: ########## @@ -0,0 +1,111 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package grails.orm; + +import groovy.lang.MissingMethodException; + +/** Enum representing the supported methods in HibernateCriteriaBuilder. */ +public enum CriteriaMethods { Review Comment: Valid concern — the extensibility point was important. In this revision, `HibernateCriteriaBuilder` method dispatch was internalized, but the intent is that extension happens via Groovy extension modules on `AbstractDetachedCriteria` rather than subclassing the builder. If that's not sufficient for existing use cases, we should revisit the design before merge. Happy to discuss the specific extensibility needs. ########## grails-datamapping-core/src/main/groovy/org/grails/datastore/gorm/proxy/GroovyProxyFactory.groovy: ########## @@ -46,11 +47,10 @@ class GroovyProxyFactory implements ProxyFactory { getProxyInstanceMetaClass(object) != null } - @Override @Override Class<?> getProxiedClass(Object o) { if (isProxy(o)) { - return o.getClass().getSuperclass() + return o.getClass() Review Comment: Noted — the regression concerns around `getProxiedClass()` are being tracked on Scott's PR (#15650 targeting `7.2.x`). The H7 branch carries the same fix; if regressions surface there, they'd apply here too. I'll keep this thread open until Scott's PR is resolved and we have more clarity. ########## grails-data-mongodb/docs/build.gradle: ########## @@ -63,7 +63,12 @@ dependencies { } rootProject.subprojects .findAll { it.findProperty('gormApiDocs') } - .each { documentation project(":$it.name") } + .each { + // TODO: This needs fixed for hibernate 7, but with the hibernate version conflicts, we may need to do separate documentation publishing Review Comment: Deferring to @jamesfredley — the MongoDB docs build is out of scope for this H7 PR. @jamesfredley, please take a look at this separately and let us know your preference. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
