codeconsole commented on PR #15743: URL: https://github.com/apache/grails-core/pull/15743#issuecomment-4762779537
I went through #15678's current diff (100 files): it's entirely in `grails-data-hibernate5`/`grails-data-hibernate7` (plus graphql and gradle), and the datastore-creation rework there is on the Hibernate datastores. It doesn't touch `DefaultConnectionSource` or anything else in `grails-datastore-core`, nor `MongoDatastore` — the files this PR changes — so there's no file overlap and this rebases cleanly when #15678 lands. The change here is also additive (a new `DefaultConnectionSource` constructor; the existing one is unchanged), so it doesn't alter the creation path for stores that don't opt in. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
