The GitHub Actions job "CI" on grails-core.git/7.0.x-remove-EnableWebMvc has 
failed.
Run started by GitHub user codeconsole (triggered by codeconsole).

Head commit for run:
b05894e5e76650aa575696dab359d8df83c8c2ab / Scott Murphy Heiberg 
<[email protected]>
Keep Grails' GrailsWebRequest bound once WebMvcAutoConfiguration is active

With @EnableWebMvc no longer auto-injected, Boot's WebMvcAutoConfiguration 
becomes
active and registers an OrderedRequestContextFilter (order -105). That runs 
between
GrailsWebRequestFilter (-150) and the Spring Security chain (-100) and rebinds 
a plain
ServletRequestAttributes, so security-chain code that expects a 
GrailsWebRequest fails
with a ClassCastException (HTTP 500 on every request).

Boot's filter is @ConditionalOnMissingBean({RequestContextListener, 
RequestContextFilter}),
so make GrailsWebRequestFilter extend RequestContextFilter (it already overrides
shouldNotFilterAsyncDispatch/ErrorDispatch identically and binds a richer 
request context)
and expose it as a bean that the FilterRegistrationBean wraps. Boot then backs 
off in
favour of Grails' request-context binding.

Report URL: https://github.com/apache/grails-core/actions/runs/27935414170

With regards,
GitHub Actions via GitBox

Reply via email to