jamesfredley commented on code in PR #15770:
URL: https://github.com/apache/grails-core/pull/15770#discussion_r3483788537
##########
grails-gradle/plugins/src/main/groovy/org/grails/gradle/plugin/core/GrailsGradlePlugin.groovy:
##########
@@ -665,7 +668,7 @@ ${importStatements}
}
// Exactly one Grails BOM is ever applied (the BOMs are split by
integration:
- // default / hibernate5 / micronaut). A Micronaut project selects the
Micronaut
+ // default / hibernate / micronaut). A Micronaut project selects the
Micronaut
// variant either by setting grails { bom = 'grails-micronaut-bom' }
(auto-applied
// as an enforcedPlatform by applyGrailsBom) or by opting out via
grails { bom = null }
// and declaring enforcedPlatform(grails-micronaut-bom) by hand.
Either way the
Review Comment:
Thanks. I checked the current plugin ordering:
`applyDefaultPlugins(project)` registers `applyGrailsBom(project)` before
`configureMicronaut(project)` registers validation, so the auto-injected BOM is
present before validation runs. I added regression coverage anyway by putting
`org.apache.grails:grails-micronaut` in the Hibernate 7 Micronaut BOM fixtures
and asserting it, so the TestKit spec now exercises the validation path and
would fail if that ordering regressed.
##########
grails-doc/src/en/guide/conf/micronaut.adoc:
##########
@@ -33,7 +33,7 @@ Here's an example build file:
----
dependencies {
// enforcedPlatform is required: it forces grails-bom-managed versions
over the
- // versions declared by the Micronaut platform (e.g. javaparser-core,
Groovy 4),
+ // versions declared by the Micronaut platform (for example Groovy 5 and
javaparser-core),
// preventing binary incompatibilities at runtime.
Review Comment:
Agreed. I updated the example and warning to say the selected Grails
Micronaut BOM versions instead of grails-bom-managed versions, and removed the
remaining ambiguous wording.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
