jamesfredley commented on PR #15557: URL: https://github.com/apache/grails-core/pull/15557#issuecomment-4832969564
### GROOVY-12106 fixed upstream - workaround on a removal path, but not removable yet (snapshot lag) Re-checked the open Groovy 5 items against upstream. The one that moved is **[GROOVY-12106](https://issues.apache.org/jira/browse/GROOVY-12106)** (*STC cannot resolve an inherited parent-trait `static` from a sub-trait body*) - the ticket behind the GraphQL `Arguable` / `ComplexTyped` inline-duplication workaround. It is now **Resolved / Fixed**, fix-versions **5.0.7** and **6.0.0-alpha-2** (Paul King, via apache/groovy#2635 / #2639). **But it cannot be removed on this branch yet - the published snapshot predates the fix.** | Fact | Value | |---|---| | Latest published `5.0.7-SNAPSHOT` | build **18**, `5.0.7-20260628.011302-18` (cut `20260628.011302`) | | GROOVY-12106 resolved | same day, **10:12** - ~9h *after* build 18 was cut | | Empirical check | `:grails-data-graphql-core:compileGroovy :compileTestGroovy --rerun-tasks --refresh-dependencies` against build 18 **still fails STC**: `Cannot find matching method org.grails.gorm.graphql.entity.dsl.helpers.Arguable#withDelegate(groovy.lang.Closure, java.lang.Object)` (same for `ComplexTyped`). | I tried the removal first (restored the plain `withDelegate(closure, (Object)argument)` / `(Object)field` calls - byte-identical to `8.0.x`) and let the compiler decide. It rejects them against the only snapshot currently available, so the inline stays for now to keep the build green. **What changed in `bae7f581cf`** (comment-only, no logic change): - Refreshed the in-code comments in `Arguable.handleArgumentClosure` and `ComplexTyped.handleField` from "*Remove once GROOVY-12106 is fixed*" to the precise current status: fixed upstream for 5.0.7, but the latest published `5.0.7-SNAPSHOT` (build 18) was cut before the fix merged and still fails STC - restore the plain `withDelegate(closure, (Object)…)` call once a snapshot containing the fix is consumed. - Updated the workarounds table and "Latest commit set" section at the top of this PR to match. **Next step (no code work needed now):** once Groovy CI publishes a `5.0.7-SNAPSHOT` build > 18 (or `5.0.7` ships), a one-line revert of each inline back to `withDelegate(closure, (Object)…)` drops both blocks. Verified green with the inline retained: `:grails-data-graphql-core:compileGroovy :compileTestGroovy --rerun-tasks` BUILD SUCCESSFUL. The other two open items are unchanged and still required: **[GROOVY-12063](https://issues.apache.org/jira/browse/GROOVY-12063)** (`ConstrainedProperty.DEFAULT_MESSAGES`, still Open) and **[GROOVY-12041](https://issues.apache.org/jira/browse/GROOVY-12041)** (GSP/controller taglib STC, still Open). Assisted-by: claude-code:claude-4.8-opus -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
