jdaugherty commented on code in PR #15766:
URL: https://github.com/apache/grails-core/pull/15766#discussion_r3498418843
##########
gradle/functional-test-config.gradle:
##########
@@ -21,6 +21,35 @@ rootProject.subprojects
.findAll { !(it.name in testProjects) && !(it.name in docProjects) &&
!(it.name in cliProjects) }
.each { project.evaluationDependsOn(it.path) }
+// After evaluationDependsOn, grails-bom is fully evaluated and its ext
properties are set.
+// Read sitemesh versions to override any stale version from a published
snapshot BOM.
+// The gsp-spring-boot test app imports the PUBLISHED grails-bom snapshot via
+// io.spring.dependency-management. If that snapshot predates the sitemesh
3.3.0-M1 bump
+// (spring-webmvc-sitemesh only exists as a standalone artifact starting at
3.3.0-M1), the
+// plugin's managed-version rule silently downgrades to 3.2.2 which cannot be
resolved.
+// This eachDependency rule runs after the spring plugin's rule and wins (last
useVersion wins).
+def grailsBomProject = rootProject.subprojects.find { it.name == 'grails-bom' }
+Map localBomVersions = grailsBomProject?.hasProperty('bomDependencyVersions')
+ ? (grailsBomProject.bomDependencyVersions as Map)
+ : Collections.emptyMap()
+
+configurations.configureEach {
+ resolutionStrategy.eachDependency {
Review Comment:
This is the wrong solution. The dependency substitution must not have been
working to require this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
