jamesfredley commented on PR #15810: URL: https://github.com/apache/grails-core/pull/15810#issuecomment-4862309727
**Pre-release review pass (2026-07-02, dual-reviewer: GPT-5.5 oracle + Codex CLI):** APPROVE - no blocking findings. Reviewed the full diff plus local context: the new `isExcludedRequestParameter(...)` helper switches exclusion matching to `equalsIgnoreCase` (locale-safe, avoids the Turkish-I pitfall of `toLowerCase()`), keeps exact-name semantics (no substring over-masking of e.g. `apiToken` when only `token` is excluded), and handles nulls. Test coverage validates mixed-case masking and that unrelated parameters stay visible; docs and config metadata were updated (including the corrected `***` mask token). CI green. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
