borinquenkid opened a new pull request, #15832:
URL: https://github.com/apache/grails-core/pull/15832

   ## Summary
   
   Stacked on #15817 (PR3 — fold `grails-data-neo4j` into root 
`settings.gradle`). This is PR4 of the migration: re-adds the example apps and 
reference docs that PR3 deliberately deferred.
   
   - Migrates 3 of the 5 standalone example apps into 
`grails-test-examples/neo4j/` (`grails3-neo4j`, `grails3-neo4j-hibernate`, 
`spring-boot`), re-authored against the monorepo's convention plugins and 
`org.apache.grails:*` coordinates rather than `git mv`'d wholesale — mirrors 
how `grails-data-graphql`'s examples were migrated in `9d7d4943d5`.
   - Drops `neo4j-standalone` (no unique coverage beyond `grails3-neo4j`) and 
`test-data-service` (duplicated mongodb's own existing `test-data-service` 
example, plus had a stray cross-plugin `mongodb-gson-templates` dependency).
   - Rewrites `grails-data-neo4j/docs/build.gradle` against the `gormApiDocs` 
marker-property pattern from `grails-data-mongodb/docs`, replacing the broken 
`fetchSource`/`rootProject.subprojects.each` standalone-build logic (including 
the hibernate7/jandex exclusion workaround that pattern requires).
   - Along the way: replicates the Jetty/`neo4j-java-driver` version forces and 
JDK `--add-opens` flags into each example app's own `build.gradle` (Gradle 
resolves each project's classpath independently, so these don't propagate from 
a project dependency); fixes stale `javax.servlet.error.exception` references 
in `error.gsp`; fixes a `MockGrailsPluginManager` compatibility gap in 
`Neo4jWithHibernateSpec`'s plugin mocking.
   - `Neo4jWithHibernateSpec`'s actual assertion (that Neo4j gets a separate 
`MappingContext` when a Hibernate plugin is present) still fails after that 
mocking fix and is marked `@PendingFeature` — a pre-existing gap in this 
example app's own test, unrelated to 
`MockGrailsPluginManager`/`Neo4jGrailsPlugin` internals that's out of scope for 
an examples/docs migration.
   
   Full details and rationale are in 
`grails-data-neo4j/GORM_REGISTRY_MIGRATION.md`'s PR4 section.
   
   ## Test plan
   
   - [x] All 3 example apps compile (main, test, integrationTest source sets)
   - [x] All 3 example apps' unit tests pass 
(`grails-test-examples-neo4j-grails3-neo4j`, `-grails3-neo4j-hibernate`, 
`-spring-boot`)
   - [x] `grails-data-neo4j-docs`'s `asciidoctor` and `groovydoc` tasks both 
execute successfully
   - [ ] Full repo-wide `./gradlew build -PskipTests` re-check (attempted 
locally but couldn't be completed due to an environment/session constraint 
unrelated to the build itself — every narrower check above passed, and PR3 
already validated a full build with the broader wiring)
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to