codeconsole commented on code in PR #13863:
URL: https://github.com/apache/grails-core/pull/13863#discussion_r3546849743
##########
grails-controllers/build.gradle:
##########
@@ -63,6 +63,10 @@ dependencies {
testImplementation 'jakarta.servlet:jakarta.servlet-api'
testImplementation 'org.springframework:spring-test'
+ // WebApplicationContextRunner verifies Boot's WebMvcAutoConfiguration
backs off its RequestContextFilter
Review Comment:
Removed — dropped the empty configuration closure and its comment on the
`spring-test` `compileOnly` dependency.
##########
grails-controllers/src/main/groovy/org/grails/plugins/web/controllers/ControllersAutoConfiguration.java:
##########
@@ -108,13 +108,24 @@ public FilterRegistrationBean<Filter>
hiddenHttpMethodFilter() {
return registrationBean;
}
+ // Exposed as a RequestContextFilter bean (GrailsWebRequestFilter extends
it) so that Boot's
Review Comment:
Simplified — condensed to the two essential points (`GrailsWebRequestFilter`
is a `RequestContextFilter` so Boot backs off, and the registration-bean-name
gate so a user overriding only that registration makes this raw filter back off
with it).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
