Copilot commented on code in PR #15949:
URL: https://github.com/apache/grails-core/pull/15949#discussion_r3555251634
##########
grails-test-examples/external-configuration/grails-app/conf/application.yml:
##########
@@ -99,6 +99,15 @@ environments:
jdbcInterceptors: ConnectionState
defaultTransactionIsolation: 2 # TRANSACTION_READ_COMMITTED
---
+# Lenient enum values resolved via environment.getProperty(name, Access)
rather than
+# relaxed configuration-property binding - regression test for issue #15818
+management:
+ endpoint:
+ heapdump:
+ access: unrestricted
+ threaddump:
+ access: read-only
Review Comment:
This example app’s default config sets `management.endpoint.heapdump.access:
unrestricted` for all profiles. Even though it’s for a regression test, it’s
easy to run this sample outside tests, and an unrestricted heapdump endpoint is
a risky default. Consider scoping this YAML document to the `test` profile (or
the integration-test profile you run these specs under) so the relaxed-value
fixture doesn’t weaken non-test runs of the example app.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
