jdaugherty commented on code in PR #15944:
URL: https://github.com/apache/grails-core/pull/15944#discussion_r3555414032
##########
grails-forge/grails-forge-core/src/main/java/org/grails/forge/feature/database/DatabaseDriverFeature.java:
##########
@@ -56,8 +56,8 @@ public void processSelectedFeatures(FeatureContext
featureContext) {
if (!featureContext.isPresent(TestContainers.class) && testContainers
!= null) {
featureContext.addFeature(testContainers);
}
- if (!featureContext.isPresent(HibernateGorm.class) && hibernateGorm !=
null) {
- featureContext.addFeature(hibernateGorm);
+ if (!featureContext.isPresent(GormFeature.class) &&
grailsDataHibernate5 != null) {
Review Comment:
the behavior change was not intended. The guard now targets
DatabaseDriverConfigurationFeature (implemented only by the two Hibernate
features), so mongo + SQL-driver output is byte-identical to pre-PR, and a test
locks it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
