jdaugherty commented on PR #15937: URL: https://github.com/apache/grails-core/pull/15937#issuecomment-4935373706
Review feedback addressed in 75605d7: 1. **Interrupt handling** — the filter now re-interrupts and returns instead of continuing the chain on an interrupted thread; covered by a new unit test asserting the chain is never invoked. 2. **Zero-probability test** — configured delay reduced from 30s to 5s so a failure trips quickly instead of hanging. 3. **Functional spec timing gap** — example now uses `min-delay: 3s` / `max-delay: 4s` with the fast-path bound at 3s. 4. **Seed reproducibility** — caveat added to the `seed` javadoc and the guide (shared generator means delay-to-request assignment is order-dependent under concurrency); delay generation now uses `random.nextLong(min, max + 1)`. 5. **Thread-pool note** — added next to the CI-usage paragraph in the docs. Also from the Copilot comments: elapsed-time assertions compare nanoseconds instead of truncated millis, and probability validation now rejects NaN/Infinity (with new test rows). Verified locally: `:grails-testing-support-latency:build` green (11 unit tests) and `:grails-test-examples-latency:integrationTest` green (2 tests). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
