codeconsole commented on PR #15757:
URL: https://github.com/apache/grails-core/pull/15757#issuecomment-4940173712

   Following up on your "at a max I would only be OK stripping parts of that 
file that are no longer needed and are explicitly duplicative of spring 
defaults" — done in d2422cdab8. The generated `logback-spring.xml` (skeleton 
and Forge) now composes Spring Boot's own `defaults.xml` + 
`console-appender.xml` instead of hand-copying them, uses Boot's default `INFO` 
root level instead of `ERROR` (so new apps no longer swallow WARN/INFO output), 
and keeps the `<springProfile name="development">` block for 
environment-specific logging:
   
   ```xml
   <?xml version="1.0" encoding="UTF-8"?>
   <configuration>
       <include 
resource="org/springframework/boot/logging/logback/defaults.xml"/>
       <include 
resource="org/springframework/boot/logging/logback/console-appender.xml"/>
   
       <root level="INFO">
           <appender-ref ref="CONSOLE"/>
       </root>
   
       <springProfile name="development">
           <logger name="StackTrace" level="ERROR"/>
   
   <!--        <logger name="com.example.myapp" level="DEBUG"/>-->
   
   <!--        <logger name="org.hibernate.SQL" level="DEBUG"/>-->
   <!--        <logger name="org.hibernate.type.descriptor.sql.BasicBinder" 
level="TRACE"/>-->
   <!--        <logger name="org.springframework.security" level="TRACE"/>-->
       </springProfile>
   
   <!--    logging to a file: set logging.file.name in application.yml and 
include Spring Boot's file appender -->
   <!--    <include 
resource="org/springframework/boot/logging/logback/file-appender.xml"/>-->
   <!--    <root level="INFO">-->
   <!--        <appender-ref ref="FILE"/>-->
   <!--    </root>-->
   </configuration>
   ```
   
   (The commented example logger is rendered with the app's actual default 
package. This also fixes a leftover hard-coded `Test38` logger name that the 
skeleton file had been shipping.)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to