jamesfredley commented on PR #15957: URL: https://github.com/apache/grails-core/pull/15957#issuecomment-4986023873
## Review feedback addressed Pushed `0a1f09df85` and `a20c06fc82` after merging the latest `8.0.x`. **Copilot review comments (all four resolved):** 1. *Constructor does not validate its `BeanBuilder`* - added `Assert.notNull(beanBuilder, ...)` plus a null-argument test. 2. *`grails.spring.BeanRegistryAdapter` collides with Spring's `org.springframework.beans.factory.support.BeanRegistryAdapter`* - renamed the interface to `GrailsBeanRegistryAdapter` and the impl to `BeanBuilderGrailsBeanRegistryAdapter` (files `git mv`d; test, docs and TOC updated; repo grep confirms no dangling references to the old names). 3. *`@since 8.1` vs an 8.0.x target* - aligned `@since` to `8.0.x` and the guide wording to "Grails 8.0". 4. *New `.adoc` missing the ASF license header + misleading "#15824" wording* - added the standard ASF header block and softened the reference to "See PR #15824 for related work". **Additional review-pass fix (`a20c06fc82`):** the guide previously described a future "BeanRegistrar-backed implementation". `BeanRegistrar` is a Spring registration callback (already integrated in Grails 8), not a registry backend, so the wording now scopes the adapter to the remaining `BeanBuilder` DSL paths and refers to Spring's `BeanRegistry` registration APIs as the future target. Local verification: `:grails-spring:test --tests grails.spring.BeanBuilderGrailsBeanRegistryAdapterTest` (2 tests) and `:grails-spring:compileTestGroovy` pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
