jamesfredley commented on PR #15960: URL: https://github.com/apache/grails-core/pull/15960#issuecomment-4997825654
Thanks for the context on the GPars-into-Groovy discussions with @paulk-asert. To separate the two things this PR touches: the **deprecation of GPars** and the **modern virtual-thread path** are independent decisions, and I'd propose decoupling them here. - **We can leave GPars non-deprecated.** This PR does not need to deprecate or remove `grails-async-gpars` / `grails-events-gpars`. Dropping the deprecation respects the ongoing Groovy/GPars integration discussion, and nothing in the virtual-thread seed depends on it. - **What's worth landing is the modern path itself.** A `VirtualThreadPromiseFactory` in `grails-async-core` is additive and opt-in - it gives applications on the JDK 21 baseline a maintained, native concurrency option alongside GPars, which is exactly the "virtual threads are the modern answer" direction in the pre-release review (Codebase 3 / guardrail: prioritize virtual threads, do not add a reactive/R2DBC stack). - **Context, not a forcing function:** GPars is at 1.2.1 (2014) and the upstream project is dormant, so the value of offering a virtual-thread-backed factory stands on its own regardless of GPars' lifecycle. I'll add a note to the PR capturing the GPars release age as motivation for the modern path, without implying an 8.x deprecation. I'll rescope the PR to "add the VirtualThreadPromiseFactory seed" with GPars left as-is. Does that address the concern? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
