jamesfredley commented on PR #15961: URL: https://github.com/apache/grails-core/pull/15961#issuecomment-4997826093
Good call to check - I looked at #15091, and it's complementary rather than overlapping. #15091 (@matrei, "fix(deps): clarify and update usage of `caffeine`") is dependency cleanup: it removes unused *direct* Caffeine deps from `grails-core` / `grails-data-simple` and adds explanatory comments in the modules that do use Caffeine (`grails-web-common`, `grails-web-url-mappings`). It changes **no** files in `grails-cache` and doesn't touch `GrailsConcurrentLinkedMapCache`, `concurrentlinkedhashmap-lru`, or the cache implementation. So it did not perform this migration - #15961 is the functional swap of the cache internals. The two just need dependency-resolution coordination once both are in flight. On the "architectural shift, not discussed as a team" point - fair, and I'll take it to the dev list / weekly before proceeding rather than merging unilaterally. For grounding, the migration is a documented codebase-improvement recommendation (pre-release review, Codebase 3): - `concurrentlinkedhashmap-lru` is 1.4.2 (2015, archived), and its own author built **Caffeine as the successor**. - It's used only by `grails-cache`'s `GrailsConcurrentLinkedMapCache`. - Caffeine is Spring's preferred cache provider, so migrating aligns `grails-cache` with the Boot 4 ecosystem, and lets us deprecate/remove the archived dependency. The plan I'd bring to the discussion: swap the internals of `GrailsConcurrentLinkedMapCache` to Caffeine behind the existing cache API, add behavioral tests, and stage the old dependency for removal - keeping public behavior stable. I'll hold merge until we've talked it through as a team. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
