jamesfredley commented on PR #15814: URL: https://github.com/apache/grails-core/pull/15814#issuecomment-4999160913
Final review fixes are pushed in `4adff56413`. The public analytics GET test now returns `200 []` using a mocked `FeatureRepository`, all aggregate methods retain `@ReadOnly`, and the security spec uses a test-only transaction factory plus a lifecycle-managed HTTP client. `AnalyticsControllerSecuritySpec` passes 4/4 and `HstsHeaderFilterSpec` passes with no analytics audience environment variable set. The exact 19-file PR diff completed Oracle and Codex review GREEN. The persistence-path test remains locally blocked before execution by the Testcontainers 1.20.6 / Docker 29.5.3 API incompatibility documented in the PR description. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
