Copilot commented on code in PR #16000: URL: https://github.com/apache/grails-core/pull/16000#discussion_r3605412376
########## grails-core/src/main/groovy/grails/boot/config/ArtefactIndexReader.java: ########## @@ -0,0 +1,83 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package grails.boot.config; + +import java.io.BufferedReader; +import java.io.IOException; +import java.io.InputStream; +import java.io.InputStreamReader; +import java.net.URL; +import java.nio.charset.StandardCharsets; +import java.util.Collection; +import java.util.LinkedHashSet; +import java.util.Set; + +import grails.io.IOUtils; + +/** + * Reads the optional application artefact index. + * + * <p>The index is UTF-8 text at {@value #RESOURCE_NAME}, with one fully qualified + * class name per nonempty line. Any unreadable or unresolvable entry rejects the + * complete index so callers can use their normal classpath scan.</p> + */ Review Comment: The Javadoc says the index contains one class name per “nonempty line”, but the implementation treats any empty line as a fatal format error (and also ignores entries that don’t match the provided packageNames filter). Please update the Javadoc to reflect the actual parsing/validation rules so index producers don’t get conflicting guidance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
