bito-code-review[bot] commented on PR #16004:
URL: https://github.com/apache/grails-core/pull/16004#issuecomment-5007832797
<!-- Bito Reply -->
To make the selection safe and avoid `NoSuchElementException` when the list
is empty, you can use `.find()` or `.first()` with a default value, or check
the size before accessing. Given the context of the test, using `find { true }`
or checking the list size is appropriate to ensure the `then:` block handles
the failure reporting correctly.
Here is the suggested update for the test:
```groovy
when:
def tailPlugins = manager.getAllPlugins().findAll { it.name ==
'registryOrderingTail' }
def expectedTailPlugin = tailPlugins ? tailPlugins.first() : null
def pluginByName = manager.getGrailsPlugin('registryOrderingTail')
```
This change ensures that `expectedTailPlugin` is `null` if the list is
empty, allowing the subsequent assertions in the `then:` block to fail
gracefully with descriptive messages rather than throwing an exception.
**grails-core/src/test/groovy/grails/plugins/DefaultGrailsPluginManagerRegistryContractSpec.groovy**
```
when:
def tailPlugins = manager.getAllPlugins().findAll { it.name ==
'registryOrderingTail' }
def expectedTailPlugin = tailPlugins ? tailPlugins.first() : null
def pluginByName = manager.getGrailsPlugin('registryOrderingTail')
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
