borinquenkid opened a new pull request, #16005:
URL: https://github.com/apache/grails-core/pull/16005

   Continues #15327 by @sanjana2505006 — rebases onto current 7.0.x and 
addresses @jdaugherty's outstanding review feedback:
   
   - Removes the stray `TEST_FAILURES.md` that was accidentally committed 
(flagged in #15327, never addressed).
   - Decouples `auditGroovydocLinks` from the default `docs` build so it can't 
fail every future docs build on a false positive. jdaugherty's last comment on 
#15327: *"The audit should be a task we run, but it shouldn't be run by default 
unless we're going to capture it in the workflow summary of the build."* It 
remains available on demand: `./gradlew :grails-doc:auditGroovydocLinks`.
   - Extracts the link-violation-detection logic into a Gradle-API-free 
`GroovydocLinkAuditor` class with unit tests (`build-logic/docs-core` 
deliberately keeps Gradle classes off the test compile classpath, so the 
previous `DefaultTask`-only implementation had no path to test coverage).
   
   Verified against a full `aggregateGroovydoc` run on current `7.0.x` (all 60+ 
modules): **0 violations** — the ~30 phantom-link false positives Sanjana 
observed earlier in the PR's life (from the old Python-script-based approach) 
no longer reproduce with the current native-Groovy audit logic.
   
   Closes #15327.
   
   Co-Authored-By: Sanjana <[email protected]>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to