jdaugherty commented on PR #15948: URL: https://github.com/apache/grails-core/pull/15948#issuecomment-5011951547
@jamesfredley Given that: 1. your time is limited right now to respond & this needs to make it into tomorrow's milestone stage 2. your comment wasn't a blocking change (requested changes) 3. all of the comments have been addressed except those that exist with the current code line (gradle task names / incremental compile) 4. this change doesn't require rebuilding every grails plugin (only if you want the commands, which would indicate active development) 5. there are multiple other approvals 6. we can always iterate on this design before a RC or the final release I'm going to merge this after the tests finish. If you feel this needs reverted, let's revisit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
