jamesfredley commented on code in PR #16011:
URL: https://github.com/apache/grails-core/pull/16011#discussion_r3610546265
##########
grails-core/src/cli/groovy/org/apache/grails/core/cli/ApplicationContextCommandRegistry.groovy:
##########
@@ -29,21 +33,73 @@ import org.grails.core.io.support.GrailsFactoriesLoader
@Singleton(strict = false)
class ApplicationContextCommandRegistry {
+ private static final Logger LOG =
LoggerFactory.getLogger(ApplicationContextCommandRegistry)
Review Comment:
Good suggestion - switched to the annotation in 5069bef718. I used plain
`@Slf4j` (which generates a `log` field) rather than `@Slf4j('LOG')`, to match
the dominant convention across the codebase: unqualified `@Slf4j` is used 162
times - including the sibling `ConfigReportCommand` in this same package -
while `@Slf4j('LOG')` appears zero times. The two call sites now use
`log.warn(...)` and the manual `Logger`/`LoggerFactory` field is gone.
##########
grails-core/src/cli/groovy/org/apache/grails/core/cli/ApplicationContextCommandRegistry.groovy:
##########
@@ -29,21 +33,73 @@ import org.grails.core.io.support.GrailsFactoriesLoader
@Singleton(strict = false)
class ApplicationContextCommandRegistry {
+ private static final Logger LOG =
LoggerFactory.getLogger(ApplicationContextCommandRegistry)
Review Comment:
Good suggestion - switched to the annotation in 5069bef718. I used plain
`@Slf4j` (which generates a `log` field) rather than `@Slf4j('LOG')`, to match
the dominant convention across the codebase: unqualified `@Slf4j` is used 162
times - including the sibling `ConfigReportCommand` in this same package -
while `@Slf4j('LOG')` appears zero times. The two call sites now use
`log.warn(...)` and the manual `Logger`/`LoggerFactory` field is gone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
