jdaugherty commented on code in PR #15666: URL: https://github.com/apache/grails-core/pull/15666#discussion_r3610658939
########## grails-doc/src/en/guide/conf/config/logging/loggingFullStackTraces.adoc: ########## @@ -97,6 +97,13 @@ log record. It means non-resolver code paths (for example, a scheduled job that `GrailsUtil.sanitizeRootCause(ex)` before logging via its own logger) continue to populate the `StackTrace` appender without an explicit emission call. +NOTE: `GrailsUtil` honours the same config keys as the exception resolver Review Comment: This NOTE bakes internal wiring into the user guide — `GrailsExceptionResolver` and `GroovyPageView` are both `org.grails.*` internal packages, and we shouldn't reference internal APIs in user-facing docs. Can we state the behaviour only, e.g. "`GrailsUtil` honours the same config keys once the application has started, so this property controls both resolver-driven and `GrailsUtil`-driven emission (including GSP view-rendering errors)"? Then the docs also don't need to change when the wiring does. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
