The GitHub Actions job "Coverage" on grails-intellij-plugin.git/main has failed. Run started by GitHub user jdaugherty (triggered by jdaugherty).
Head commit for run: 731dfdd41b717a5381befc40bac272927a34847a / James Daugherty <[email protected]> Repackage every project to group + artifact, and rename the plugin to Apache Grails 889 files move so each project's base package equals its Gradle group plus artifact short name, and so no package is shared between two projects: plugin org.apache.grails.intellij.plugin pluginModules/<name> org.apache.grails.intellij.module.<name> libs/gradle-tooling org.apache.grails.intellij.lib.gradle.tooling libs/grails-rt org.apache.grails.intellij.lib.grails.rt libs/testFramework org.apache.grails.intellij.lib.testFramework compilers/grails-compiler-patch org.apache.grails.intellij.compiler.grails.compiler.patch compilers/jps-plugin org.apache.grails.intellij.compiler.jps.plugin Hyphens in artifact names are illegal in package segments, so they split on the hyphen. That leaves grails-compiler-patch stuttering as compiler.grails.compiler.patch; kept literal for consistency with the rule rather than special-cased -- say so and I will shorten it. Two packages were owned by two projects each, which is exactly what this was meant to end: org.jetbrains.plugins.groovy.grails (libs/testFramework's 5 classes plus 23 plugin tests) and com.intellij.groovy.grails.copyright (the copyright module plus one plugin test). Targets are therefore computed per file from (project, old package); a prefix rewrite cannot tell the owners apart. Verified afterwards: no package is shared. Consequences of splitting those packages, which the compiler found: - 16 plugin tests referenced GrailsTestCase and friends with no import, because they used to share testFramework's package. Imports added. - GspCopyrightUpdaterTest used UpdateGspCopyrightsProvider the same way. That class is registered by FQN in the copyright module descriptor, so it is already part of that module's surface and is now public rather than moving the test back into the module's package, which would have re-created a split package. - GrailsScriptProvider sat in the platform's org.jetbrains.plugins.groovy.dsl and so resolved GdslScriptProvider without an import; it needs one now. libs/testFramework keeps its vendored com.intellij.* / org.jetbrains.plugins.gradle.* / org.jetbrains.plugins.groovy.* copies -- those only work because their FQN matches the platform's -- so it is the one project without a single base package. Moved in lockstep with the classes: 227 descriptor FQNs, plugin.xml's package= prefix, 8 .form bindings, both META-INF/services entries, grails-rt's Premain-Class manifest attribute, and the two GrailsIdeaTestListener strings that cross into the user's build. The .flex lexer inputs carry wildcard imports of our own packages and moved too. Plugin display name is now "Apache Grails" (the Marketplace id stays org.intellij.grails per MIGRATION-PLAN decision 2). Verified: 996 tests / 0 failures; rat clean; buildPlugin clean; all 227 descriptor references resolve and none still name an old package. Note the suite reports 189 classes / 996 tests where I previously recorded 188 / 991 -- GspCopyrightUpdaterTest appears in this run and its declaration is unchanged at HEAD, so I have not explained the delta and am not claiming the rename caused it. Report URL: https://github.com/apache/grails-intellij-plugin/actions/runs/30220422693 With regards, GitHub Actions via GitBox
