The GitHub Actions job "CI" on grails-core.git/fix/groovydoc-links has failed. Run started by GitHub user borinquenkid (triggered by borinquenkid).
Head commit for run: 45a938c8c131ba682a5b0b622c187dd7bdf66927 / Walter Duque de Estrada <[email protected]> Address jdaugherty and Copilot review feedback on groovydoc link audit Fixes the CHANGES_REQUESTED review comments left unaddressed on this PR: - Wire auditGroovydocLinks.apiDocsDir via Provider (project.layout.dir( combinedGroovydoc.map { it.destinationDir })) instead of an eager combinedGroovydoc.get(), so the dependency is implicit and the task isn't realized during configuration. - Drop the NAV_LINK_PATTERNS check entirely rather than reworking it: those patterns never matched real (double-quoted) Groovydoc output, so "0 violations" reflected dead code, not clean docs. Reworking it to flag unresolved targets was tried and reverted after verifying against real generated output - groovy-groovydoc's package-summary template omits the relative-root prefix on its bottom nav bar for every package, which would flag ~330 instances of that one known tool quirk per module. The inner-class check (the genuinely valid part, per review) is unaffected and still the sole detector. - Remove the AuditGroovydocLinksTask directory-exists guard: it's dead code, since @InputDirectory already fails task validation before @TaskAction runs if the directory is missing. - Import GradleException instead of using the inline FQCN. - Fix the org.springframework[.boot]. link ordering: Groovydoc resolves links first-match-wins, so the broader entry sitting before the more specific one was making every Spring Boot link resolve against the Framework javadocs, where the Boot classes don't exist. - Derive the Jakarta spec/platform versions from the resolved artifact versions instead of hardcoding them - the servlet link was already stale on this branch (hardcoded platform/10, but 7.0.x resolves servlet-api 6.1.0, i.e. platform 11). - Derive the Groovy javadoc link from the resolved groovy version instead of "latest" (which serves Groovy 5 docs; 7.0.x ships 4.0.32). - Remove the org.grails.datastore./grails.gorm./org.grails.gorm. external link mappings: those classes are generated directly in this repo's own aggregate Groovydoc since the data modules merged in 7.0, so mapping them externally to gorm.grails.org misdirects local links. Verified the corrected GroovydocLinkAuditor against real generated Groovydoc output (grails-core module and the full grails-doc aggregate combinedGroovydoc): 0 violations, with the fixed link-order/version values confirmed present in the resolved links list. Co-Authored-By: Claude Sonnet 5 <[email protected]> Report URL: https://github.com/apache/grails-core/actions/runs/30288064024 With regards, GitHub Actions via GitBox
