The GitHub Actions job "CI" on grails-core.git/feat/url-mapping-precompute-seed has succeeded. Run started by GitHub user borinquenkid (triggered by borinquenkid).
Head commit for run: 3034e47e81c3b7f0b1869c772aa7011eaedba7e9 / Walter Duque de Estrada <[email protected]> Improve UrlMappingsIndexProperties patch coverage Codecov flagged 70.59% patch coverage (5 missing, 3 partial lines across UrlMappingsIndexProperties.java and DefaultUrlMappingsHolder.java). Verified jamesfredley's prior review-feedback fix (TCCL-first classloader order, per-loader IOException|RuntimeException isolation) against the current code first - it's correct as claimed. Closed the reachable gaps: - propertyNames() was never called by any test. - The null-thread-context-classloader fallback path (loader == null -> continue to the provided classloader) was untested; a real JVM's TCCL is essentially never null in practice, but it's legal to set explicitly and is a real defensive branch worth locking in. - The LOG.debug(...) line reporting a discovered descriptor never ran because the module's tests default to INFO. Added a per-logger DEBUG override in simplelogger.properties (scoped to just these two loggers) rather than a fragile system-property timing dependency, verified the full module suite still passes with it enabled. Left two gaps deliberately uncovered, consistent with judgment calls made elsewhere in this PR-review pass today: the TCCL-retrieval RuntimeException catch (Thread.getContextClassLoader() only throws under a SecurityManager, which is disallowed by default since JDK 18 on this JDK 21 baseline - a test would need to force-enable a deprecated-for-removal mechanism to reach genuinely dead code on this baseline), and DefaultUrlMappingsHolder's own debug-log line (only reachable when a real META-INF/grails/url-mappings-index.properties exists on DefaultUrlMappingsHolder's own hardcoded classloader - not injectable - so covering it needs a classpath-crafted forked-process test for two lines of pure logging with no behavioral significance). Result: UrlMappingsIndexProperties.java goes from 5 missing/3 partial to 2 missing/2 partial lines; full module test suite remains green. Co-Authored-By: Claude Sonnet 5 <[email protected]> Report URL: https://github.com/apache/grails-core/actions/runs/30302559574 With regards, GitHub Actions via GitBox
