The GitHub Actions job "CI" on grails-core.git/spike/grails-beans-dsl has succeeded. Run started by GitHub user codeconsole (triggered by codeconsole).
Head commit for run: 29305023f40e8c6ed1f2aba24c54ddc704c5366c / Scott Murphy Heiberg <[email protected]> Drop the dead GrailsConfigurationAware contract from GrailsPlaceholderConfigurer GrailsPlaceholderConfigurer declared itself GrailsConfigurationAware and branched on the resulting Config in loadProperties, but that branch could never run. The interface is populated by GrailsApplicationAwareBeanPostProcessor, a BeanPostProcessor, and this class is a BeanFactoryPostProcessor created during invokeBeanFactoryPostProcessors - before any BeanPostProcessor is registered - so setConfiguration was never called and the field stayed null. Both the placeholder-prefix bug fixed earlier in this branch and the auto-timestamp cache default traced back to code assuming otherwise. Removing it loses nothing. In production the class is constructed with the no-argument constructor, so the properties field is null as well and loadProperties contributes nothing either way; resolution falls through to PropertySourcesPlaceholderConfigurer's own environment-backed sources. The Grails config is itself built from those sources, so a ${...} placeholder naming a key from application.yml resolves through the environment, which is what the dead branch was duplicating. The two-argument constructor taking an explicit Properties is untouched and still feeds loadProperties, which is the path GrailsPlaceholderConfigurer's own specs exercise; all five placeholder specs pass unmodified. Config stays imported because doProcessProperties still uses it to keep the bean definition visitor from walking the whole Grails config. GrailsConfigurationAware itself is unaffected and remains public, documented API. It is populated correctly for ordinary beans; only classes instantiated ahead of the BeanPostProcessor phase - which no longer includes any framework class - cannot receive it. Report URL: https://github.com/apache/grails-core/actions/runs/30317638628 With regards, GitHub Actions via GitBox
