borinquenkid commented on PR #16065: URL: https://github.com/apache/grails-core/pull/16065#issuecomment-5133636812
The CI failures on this PR (`Build Grails-Core` failing on ubuntu-latest/macos-latest/windows-latest, "Rerunning all Tasks") are pre-existing on `8.0.x` and unrelated to this change. Both failures are the same root cause: - `GrailsBootstrapRegistryInitializerSpec > defaults logFullStackTraceOnFilter to true on the promoted DefaultStackTraceFilterer` - `GrailsUtilStackFiltererSpec > installed DefaultStackTraceFilterer emits Full Stack Trace by default` Both assert on a `System.err`-backed `ByteArrayOutputStream` capture of the stack trace filterer's output, but `8.0.x` now routes that output through a Logback appender instead of `System.err`, so the capture is empty. This branch depends on #16067 (`fix: capture STACK_LOG output via a Logback appender instead of System.err`) merging into `8.0.x` first. Once that lands, I'll rebase this branch onto the updated `8.0.x` and CI should go green. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
