jamesfredley commented on code in PR #16073:
URL: https://github.com/apache/grails-core/pull/16073#discussion_r3687294087
##########
settings.gradle:
##########
@@ -609,28 +609,9 @@ project(':grails-test-examples-jetty').projectDir =
file('grails-test-examples/j
project(':grails-test-examples-undertow').projectDir =
file('grails-test-examples/undertow')
project(':grails-test-examples-latency').projectDir =
file('grails-test-examples/latency')
-// The Spring Dependency Management example imports grails-bom as a Maven BOM
through
-// io.spring.dependency-management, which resolves BOM imports with its own
detached
-// configurations. Those bypass the local-project substitution rules in
-// gradle/functional-test-config.gradle, so the import only works when
-// org.apache.grails:grails-bom:<projectVersion> is already published to a
repository.
-// During a release (reproducible build, SOURCE_DATE_EPOCH set) the version
being staged
-// is not published anywhere yet, so the example cannot resolve its
dependencies -
-// exclude it from the build graph entirely. It still builds and runs on every
regular
-// CI build, where the -SNAPSHOT BOM is available from the Apache snapshots
repository.
-//
-// A newly created release branch is the same condition: the moment
projectVersion is
-// bumped to a version that has never been published, the BOM import silently
resolves
-// to nothing, every managed version comes back empty, and the whole build
fails with
-// "Could not find <group>:<artifact>:" - before CI can ever publish the
snapshot that
-// would fix it. Set -PbomSnapshotNotPublished (or add it to
gradle.properties) on such
-// a branch to exclude the example until its first snapshot publish succeeds,
then drop
-// the flag again. The flag is presence-based; its value is ignored.
-def bomSnapshotNotPublished =
providers.gradleProperty('bomSnapshotNotPublished').isPresent()
-if (!isReproducibleBuild && !bomSnapshotNotPublished) {
- include 'grails-test-examples-spring-dependency-management'
- project(':grails-test-examples-spring-dependency-management').projectDir =
file('grails-test-examples/spring-dependency-management')
-}
+// The Spring Dependency Management example imports the in-commit BOMs from
the local Maven repository.
Review Comment:
Good catch - fixed in 6fd5248a7c. You are right that `local Maven
repository` was ambiguous, especially since `GrailsRepoSettingsPlugin` really
does call `mavenLocal()` on the `GRAILS_INCLUDE_MAVEN_LOCAL` branch nearby, so
the old wording pointed at the wrong mechanism. The comment now names the
actual path (`.gradle/local-boms`), says it is served as an `exclusiveContent`
file repository by `GrailsRepoSettingsPlugin`, and states explicitly that it is
not `mavenLocal()` and that nothing is downloaded.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
