The GitHub Actions job "CI - Groovy Joint Validation Build" on grails-core.git/naming-strategy-table-name-mapping-fix has succeeded. Run started by GitHub user borinquenkid (triggered by borinquenkid).
Head commit for run: 4da31cc034774847c4630d76ca1e5d74514280a4 / Walter Duque de Estrada <[email protected]> Narrow join-table naming fix's scope in code and docs to unidirectional hasMany jdaugherty's review confirmed resolveJoinTableForeignKeyColumnName only runs for a unidirectional hasMany join table - a bidirectional many-to-many still derives both columns from class names, unaffected by this change. Documents that scope explicitly (with a corrected, genuinely-unidirectional example) in both the upgrade guide and the naming-strategy guide, and cross-references the two, instead of describing a many-to-many schema change that doesn't happen. joinTableColumName's isBasic() ternary was dead: both of its callers (BasicCollectionElementBinder, EnumTypeBinder) always pass a HibernateBasicProperty, so the association branch never ran and was only reachable through a mocked naming strategy in the existing test. Dropped the ternary and replaced that test with one that boots a real PhysicalNamingStrategy distinguishing column from table naming and asserts the resulting join column, rather than asserting mock interaction counts on unreachable code. Renamed the test's Book domain class to HTMPMappedTableBook to match the rest of the file's HTMP-prefix convention. Co-Authored-By: Claude Sonnet 5 <[email protected]> Report URL: https://github.com/apache/grails-core/actions/runs/30592700291 With regards, GitHub Actions via GitBox
