jamesfredley commented on PR #16082:
URL: https://github.com/apache/grails-core/pull/16082#issuecomment-5158950169
## Review feedback addressed (7a3049d707)
Responding to **@jdaugherty**, Copilot, and Bito on the forced-clean
regression:
### Removed
- `cleanStaleRuntimeCommandResources` with `outputs.upToDateWhen { false }`
wired into `processResources` / `jar`
### Replaced with Gradle-owned unique outputs
- `copyCommands` / `copyTemplates` are **`Sync`** tasks writing only to
`build/tmp/grails-plugin-commands` and `build/tmp/grails-plugin-templates`
- Companion: `processCliResources.from(copyCommands) { into
'META-INF/commands' }`
- No companion: `processResources.from(copyCommands) { into
'META-INF/commands' }`
- Templates always: `processResources.from(copyTemplates) { into
'META-INF/templates' }`
### Migration leftovers (no forced clean)
When a companion is present, the runtime `jar` excludes
`META-INF/commands/*` entries that are not hand-authored under
`src/main/resources/META-INF/commands`. That drops old side-written script
copies without disabling incremental builds.
### Verification
`:grails-gradle-plugins:test --tests PluginScriptCommandPackagingSpec` green
(companion routing, non-companion legacy packaging, unique Sync dir, seeded
stale leftovers excluded, hand-authored kept).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
