jdaugherty commented on code in PR #16077:
URL: https://github.com/apache/grails-core/pull/16077#discussion_r3699736691
##########
end-to-end/settings.gradle:
##########
@@ -103,10 +104,26 @@ rootProject.name = 'grails-end-to-end'
include(
'legacy-commands',
'legacy-commands-plugin',
+ // Belongs here rather than in grails-test-examples: it imports
grails-bom as a Maven BOM
+ // through io.spring.dependency-management, which resolves imports in
its own detached
+ // configuration. That bypasses any project substitution, so the
import can only ever be
+ // satisfied by a published
org.apache.grails:grails-bom:<projectVersion> - which is what
+ // the repository above is. In the core build it had to be excluded
whenever nothing had
+ // been published yet (a reproducible release build, or a fresh
release branch whose
+ // version has never been published), and otherwise resolved against
whatever the Apache
+ // snapshot repository held rather than the working tree.
+ 'spring-dependency-management',
)
// legacy-g7-command-plugin is deliberately NOT included here. It compiles
against published
// Grails 7 / Groovy 4 artifacts, and an included build would substitute
// org.apache.grails:grails-core for this repo's Groovy 5 project - which is
exactly the
// substitution the fixture exists to avoid. It stays a standalone build, run
under its own JDK
// (legacy-g7-command-plugin/.sdkmanrc), and legacy-commands consumes the jar
it produces.
+
+// Due to https://github.com/gradle/gradle/issues/2986 , we can't change the
global exclude for profiles, it must be done everywhere
+for (String pattern in DirectoryScanner.defaultExcludes) {
+ if (pattern.contains('gitignore') || pattern.contains('gitattributes')) {
+ DirectoryScanner.removeDefaultExclude(pattern)
+ }
+}
Review Comment:
This becomes a hard error if a daemon gets reused which is why I fixed it in
this PR - I hit this locally & in CI a few times initially.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
