jamesfredley commented on PR #15950: URL: https://github.com/apache/grails-core/pull/15950#issuecomment-5160464522
@jdaugherty Addressed after merging the updated #15947 base (`50714be10c`). ## Review responses | Item | Resolution | | --- | --- | | Post-bind path re-walk (~640 lines in `DataBindingUtils`) | Extracted to package-private `NullMissingPropertyClearer` with coverage through public `bindData` / `DataBindingUtils` APIs. Clearing remains intentionally post-bind (documented). | | nullMissing only tested under secure mode | After the #15947 merge, `BindDataMethodTests` runs on the unconfigured permissive default. Added/kept default-mode coverage for clear omitted include, leave excluded, `bindable: false`, nested/indexed/map paths. Secure-mode cases stay explicit via `enableSecureBinding()`. | | Swallowed clear failures | Primitive includes reset to the type default. Clear failures produce `FieldError`s on the returned `BindingResult` (full nested path preserved); existing conversion errors are kept. | | Three disagreeing framework-property lists | Single `FrameworkPropertyNames` with intrinsic runtime vs Grails-managed sets. `SimpleDataBinder` only hard-denies intrinsic runtime properties so `bindable: true` on `id`/`dateCreated`/`lastUpdated` still works; nullMissing uses the full managed set. | | Missing javadoc on public `nullMissing` overloads | Documented: ignored without a non-null `include`; clearing runs after bind; listener/`BindingResult` behavior described. | | Public `SimpleDataBinder.isPropertyExcluded` | Removed from public API; exclusion matching lives in the web-layer clearer. | ## Verification `:grails-databinding-core:test`, `:grails-web-databinding:test`, and focused `:grails-test-suite-web:test` (`BindDataMethodTests`, `DefaultASTDatabindingHelperDomainClassSpecialPropertiesSpec`) all green. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
