Copilot commented on code in PR #16116:
URL: https://github.com/apache/grails-core/pull/16116#discussion_r3744117370
##########
.github/workflows/gradle.yml:
##########
@@ -172,20 +198,51 @@ jobs:
# and included automatically on JDK 25+. So the Java 21 entries build
everything
# except the island and the Java 25 entries build the full graph - no
flag needed.
run: >
- ./gradlew build :grails-shell-cli:installDist groovydoc
+ ./gradlew ${{ matrix.gradle_task }}
--continue
--stacktrace
-PonlyCoreTests
-PskipCodeStyle
+ ${{ matrix.shard_arguments }}
Review Comment:
`matrix.shard_arguments` is referenced in the Gradle command, but several
matrix entries (Ubuntu JDK 21/25 and macOS JDK 21) don’t define
`shard_arguments`. Depending on GitHub Actions expression handling, this can
render as `null`/empty or fail evaluation; make it explicit by defaulting to an
empty string.
This issue also appears on line 523 of the same file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
