matrei commented on code in PR #16040:
URL: https://github.com/apache/grails-core/pull/16040#discussion_r3750491608


##########
grails-doc/src/en/guide/upgrading/upgrading80x.adoc:
##########
@@ -136,6 +138,34 @@ spring:
         database: mydb
 ----
 
+===== 4.2 Multipart Upload Configuration
+
+The `grails.controllers.upload.*` configuration properties are no longer 
supported.
+Applications that still define any property under `grails.controllers.upload` 
fail at startup with migration instructions.
+Move those settings to Spring Boot's `spring.servlet.multipart.*` namespace:
+
+[source,yaml]
+.application.yml - Before (Grails 7)
+----
+grails:
+    controllers:
+        upload:
+            maxFileSize: 200000
+            maxRequestSize: 200000
+----
+
+[source,yaml]
+.application.yml - After (Grails 8)
+----
+spring:
+    servlet:
+        multipart:
+            maxFileSize: 200MB
+            maxRequestSize: 200MB
+----
+
+Spring Boot also provides `spring.servlet.multipart.location`, 
`spring.servlet.multipart.fileSizeThreshold`, and 
`spring.servlet.multipart.enabled` as replacements for the corresponding legacy 
settings.

Review Comment:
   Should now be addressed



##########
grails-doc/src/en/guide/theWebLayer/controllers/uploadingFiles.adoc:
##########
@@ -103,16 +103,19 @@ You can configure the limit in your `application.yml` as 
follows:
 [source,yml]
 .grails-app/conf/application.yml
 ----
-grails:
-    controllers:
-        upload:
-            maxFileSize: 2000000
-            maxRequestSize: 2000000
+spring:
+    servlet:
+        multipart:
+            maxFileSize: 200MB
+            maxRequestSize: 200MB
 ----
 
-`maxFileSize` = The maximum size allowed for uploaded files.
+`maxFileSize` = The maximum size allowed for an uploaded file.
 
-`maxRequestSize` =  The maximum size allowed for multipart/form-data requests.
+`maxRequestSize` = The maximum size allowed for a multipart/form-data request.
+
+The `spring.servlet.multipart` namespace also supports Spring Boot's 
`location`, `fileSizeThreshold`, and `enabled` properties.

Review Comment:
   Should now be addressed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to