borinquenkid opened a new pull request, #16135:
URL: https://github.com/apache/grails-core/pull/16135
## Summary
- Restores the grails-datamapping-rx module to the active build (was
disabled in both settings.gradle and gradle/publish-root-config.gradle pending
a port to the current Grails release)
- Fixes 7 real bugs uncovered while re-enabling it:
- RxSchedule.java: an @interface illegally declared a `default` annotation
member with a method body instead of a constant, and referenced a removed
GroovyTransformOrder constant
- grails.gorm.rx.DetachedCriteria.clone() illegally narrowed visibility
from its public parent
- RxEntity.groovy was missing `import rx.Observable`
- RxScheduleIOTransformation.groovy referenced the same stale
GroovyTransformOrder constant
- FindByFinder/FindAllByFinder (rx) called a 3-arg buildQuery(...)
overload that no longer exists after the finders' Groovy->Java conversion;
inlined the steps the current 2-arg buildQuery performs internally
- Brings the module's Checkstyle/CodeNarc compliance up to date with the
rest of the codebase (it had never been linted while disabled)
## Test plan
- [x] `:grails-datamapping-rx:compileGroovy` — BUILD SUCCESSFUL
- [x] `:grails-datamapping-rx:test` — 8/8 passing
- [x] `:grails-datamapping-rx:codeStyle` — Checkstyle + CodeNarc both clean
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
