borinquenkid opened a new pull request, #16148:
URL: https://github.com/apache/grails-core/pull/16148
## Summary
- Substantially raises test coverage across grails-datamapping-core's
compile-time AST
transform classes (the `query/transform` package plus
`DirtyCheckTransformation`,
`JpaGormEntityTransformation`, `AbstractGormASTTransformation`,
`AbstractTraitApplyingGormASTTransformation`, `OrderedGormTransformation`,
`TenantTransform`, `ServiceTransformation`) — several classes move from
0-70%
to 80-100% instruction coverage.
- Fixes three real compiler crashes surfaced while writing tests: `@Tenant`
and
`OrderedGormTransformation`'s error-reporting paths threw an internal
NullPointerException/GroovyBugError instead of a clean compile error on
malformed
input, both traced to the same root cause (an inherited `sourceUnit` field
that was
never populated).
- Cleans up static-analysis warnings on `DirtyCheckingTransformer`,
`DirtyCheckTransformation`, and `GormEntityTransformation` (unused code,
redundant
qualifiers, `equals()` vs `==`, methods that can be static), and extracts a
duplicated `visit()` guard shared across three transform classes into a new
`LocalTransformationSupport` helper.
- Documents the `protectSqlInjectionAttacks` kill-switch system property in
the
security guide.
## Test plan
- [x] Full `grails-datamapping-core` test suite green throughout
(`./gradlew :grails-datamapping-core:test`)
- [x] `codeStyle` + `codenarcMain`/`codenarcTest` clean
- [ ] CI
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
