codeconsole commented on PR #16142: URL: https://github.com/apache/grails-core/pull/16142#issuecomment-5287207189
@matrei **Why 7 and not 8:** the bug is shipping from 7.x now — jars carrying precompiled GSPs don't reproduce, and `verify-reproducible.sh` has no GSP exclusion. 8.0.x isn't released, and 7.x merges up to it anyway, so landing here covers both. Landing only on 8.0.x would leave 7.x broken. **Why not a patch:** it adds public API — `GroovyPageParser.checksumOf`, plus `getSourceChecksum`/`setSourceChecksum`. The checklist says patch branches take bug fixes only, no API changes, which is what @jdaugherty flagged. `checksumOf` can't be avoided: the compiler and `GroovyPageMetaInfo` are in different packages and must not disagree on how a source is digested. If you're fine with the API addition on a patch branch, 7.0.x works and I'll move it back. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
