codeconsole commented on PR #16146:
URL: https://github.com/apache/grails-core/pull/16146#issuecomment-5321236321
@matrei. I am a little concerned with the performance implications of not
using the DispatcherServlet (My alternate fix also has this issue).
`GrailsMultipartFilter` still eagerly resolves every multipart request in
the filter chain, ahead of `DispatcherServlet` — for every request, regardless
of whether the app needs `_method` support. That's the same shape of thing
Spring Boot moved away from in 2019.
From the Boot issue that led to `HiddenHttpMethodFilter` being disabled by
default
(https://github.com/spring-projects/spring-boot/issues/16953):
> The endpoints that were affected by this were accepting `MultipartFile`
request
> parameter - we didn't look that deep in since disabling the filter
basically fixed
> the problem and improved performance significantly but I assume this was
related to
> size of the request as `HiddenHttpMethodFilter` does
`ServletRequest#getParameter`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
