jdaugherty commented on code in PR #16165:
URL: https://github.com/apache/grails-core/pull/16165#discussion_r3812695300
##########
grails-test-examples/spring-security/ui/extended/src/integration-test/groovy/extended/spec/AclEntrySpec.groovy:
##########
@@ -76,18 +75,17 @@ class AclEntrySpec extends SecurityUISpec {
then:
page.assertResults(1, 10, 67)
- with(pageSource) {
- contains('75')
- contains('76')
- contains('78')
- contains('80')
- contains('82')
- contains('87')
- contains('89')
- contains('91')
- contains('93')
- contains('95')
- }
+ pageSource.contains('75')
Review Comment:
Why are we removing `with { }` in these assertion blocks? This is a
supported feature of spock that @matrei had added:
https://spockframework.org/spock/docs/2.5-SNAPSHOT/all_in_one.html#_using_with_for_expectations
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
