codeconsole commented on PR #16102:
URL: https://github.com/apache/grails-core/pull/16102#issuecomment-5347931186
Correcting my earlier reply on point 5: #16094 has since merged, so the
premise there ("no native build path exists") is out of date. A Grails
application can now apply `org.graalvm.buildtools.native` and the Gradle plugin
cooperates with it, and `processAot` is wired up.
That makes the ask feasible rather than impossible, so it deserved a better
answer than the one I gave. Filed as #16176.
I still don't think it belongs in this PR, for two reasons. Nothing in the
repository invokes `nativeCompile`, `nativeRun` or `nativeTest` today, and no
CI workflow provisions GraalVM — `grails-test-examples/aot` verifies
`processAot` output and a JVM startup check, both on a normal JDK. So this
isn't "add a test", it's "establish native-image CI", which would serve the AOT
cache work, GORM, GSP and anything else shipping hints, not just i18n. #16094
itself, which added the native support, didn't add a native-compile test either
— reasonably, for the same reason.
The issue captures the specific i18n assertions worth making once that
infrastructure exists, including the one open question this PR does carry:
`I18nRuntimeHintsProcessor` registers resource patterns rather than calling
`registerResourceBundle`, following Spring Boot's own choice for this case, and
only a native build can confirm that was the right call.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
