codeconsole commented on PR #16139:
URL: https://github.com/apache/grails-core/pull/16139#issuecomment-5361568215
All four addressed in 7a5df8a.
**The regression is real and is fixed.** Your repro reproduced exactly, and
so did the top-level variant. `typedSetVariables` is now one frame per emitted
block, pushed when a tag opens a body and popped when it closes: a name an
enclosing frame declared is assigned to, a name only a sibling declared is
declared again. Both your cases plus a loop-body sibling and the
enclosing-then-inner case are pinned in `GspCompileStaticConfigSpec`.
**The note** is in, close to your wording — all eleven names match what the
parser writes.
**Both minors** fixed: the stale comment is gone, and `isStrict()` now
reports `isCompileStaticGsp() && strictGsp`, so toggling strictness while `gsp`
is off no longer invalidates the task. Pinned in
`GrailsGspCompileStaticProviderSpec`.
On `${application}` compiling clean and throwing at render — agreed, and
that is why the note says precompiling will not catch it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
