The GitHub Actions job "CI" on grails-core.git/fix/cas-single-signout-and-proxy-receptor has succeeded. Run started by GitHub user sbglasius (triggered by sbglasius).
Head commit for run: 95a9eb6f1500d98435414588b8aa169626a95d56 / Søren Berg Glasius <[email protected]> fix(cas): address review feedback on metadata, docs, timeouts and style * Drop the author metadata, per ASF policy. * Restore log.warn alongside the println for the single signout warning, as SpringSecurityCoreGrailsPlugin does. The @Slf4j annotation was otherwise unused, and an application that captures logs but not stdout would never see the warning the docs promise. Trim a whitespace-only line. * Update the "Single Signout" section of the CAS guide, which still said the feature was enabled by default and only documented turning it off. * Renumber the upgrade-guide section to 48; sections 45 to 47 landed upstream while this was open, leaving two sections numbered 46. * Give the CAS requests in the specs a per-request timeout. Only a connect timeout was set, so a container that accepted the connection but never answered would block send() indefinitely and hang the job until the CI runner killed it. * Forward TESTCONFIG and casContainerVersion to bootRun, which forks its own JVM and so never saw them. /secure/proxyStatus could therefore only ever report NO_PROXY_TICKET when running the app by hand. Documented in the README, and verified that bootRun -DTESTCONFIG=casProxy now yields a real proxy ticket. * Reuse the base class's execution-token extraction in CasLoginSpec instead of duplicating it without its null guard, which turned a missing token into an opaque NPE inside URLEncoder.encode. * Correct the CasSingleSignOutSpec class comment, stale since single signout became opt-in. * Reindent SecureController with spaces to match .editorconfig. Report URL: https://github.com/apache/grails-core/actions/runs/32414477422 With regards, GitHub Actions via GitBox
