borinquenkid opened a new pull request, #16189:
URL: https://github.com/apache/grails-core/pull/16189
## Summary
- Adds Spock specs for classes in `org.grails.datastore.gorm.validation`
(grails-datamapping-core) that had no unit tests in their owning module:
`ConfigurableParameterNameProvider`, `ConstraintViolationUtils`,
`GormValidatorFactoryAdapter`, `MethodKey`,
`MappingContextAwareConstraintFactory`, `ValidatorRegistries`,
`JakartaValidatorRegistry`, and `ValidationEventListener` (previously only
covered downstream in `grails-datamapping-rx`).
- Fixes several static-analysis findings surfaced while reviewing the
package:
- `ValidationEventListener`: invalid generic cast (`Class<capture of ?
extends GormValidateable>` to `Class<Object>`) and a dead-store `boolean
hasErrors = false` initializer.
- `JakartaValidatorRegistry`: misuse of the self-bounded
`jakarta.validation.Configuration<T extends Configuration<T>>` generic.
- `MethodKey`: raw `Class[]` usage and a stale/incorrect comment on the
`equals()` implementation.
- `MethodValidationImplementer`: unused constructor parameter in
`weaveParameterNameData`.
- `GormValidatorAdapter` / `GormValidatorFactoryAdapter`: redundant `def`
modifiers on explicitly-typed generic methods.
- No behavior changes; classes touched were already exercised through public
APIs elsewhere and remain so (verified via full module test run).
## Test plan
- [x] `./gradlew :grails-datamapping-core:test` — full module suite passes
- [x] `./gradlew :grails-datamapping-core:codeStyle
:grails-datamapping-core:codenarcMain` — no violations
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
