codeconsole commented on PR #16200: URL: https://github.com/apache/grails-core/pull/16200#issuecomment-5385239449
Withdrawing this — the premise doesn't hold up. I justified the opt-out with plugins that "cannot rename": a base name that is part of a published contract, or a vendored third-party bundle. Neither survives scrutiny. Message codes are the contract and a rename doesn't touch them; nothing consumes a plugin's base name (Grails 7 discovered bundles by scanning and never read the name, and applications override messages by code in their own bundle). A vendored bundle is vendored by contents, not by file name, so renaming it costs nothing. The case that prompted this was a Spring Security fork still shipping the upstream plugin's base name. The check was right to catch it — a genuine collision — and the fix was one `git mv` loop with codes untouched, backward compatible with M5. When the remedy is that cheap, an opt-out mostly serves postponement, and postponement means shipping the collision. It also cuts against the reason the check fails hard in the first place: a warning in a plugin's own build is read by nobody, and the damage lands in someone else's application later. Not worth adding speculative configuration surface to a feature this new. Happy to revisit if someone turns up with a bundle they genuinely cannot rename. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
