matrei commented on PR #16183:
URL: https://github.com/apache/grails-core/pull/16183#issuecomment-5394863100
The way I understand it, this is the current PR behavior:
```console
// Pseudo-code
if (grailsFilterEnabled) {
if (springFilterEnabled) {
use Spring HiddenHttpMethodFilter
}
else {
use Grails HiddenHttpMethodFilter
}
disable Grails dispatcher-level override
}
else {
if (springFilterEnabled) {
use Spring HiddenHttpMethodFilter
ALSO enable Grails dispatcher-level override
}
else {
no servlet HiddenHttpMethodFilter
enable Grails dispatcher-level override
}
}
```
Wouldn't this be more appropriate?
```console
// Pseudo-code
if (springFilterEnabled) {
use Spring HiddenHttpMethodFilter
Grails compatibility/filter mode = true
}
else if (grailsFilterEnabled) {
use Grails HiddenHttpMethodFilter
Grails compatibility/filter mode = true
}
else {
no servlet HiddenHttpMethodFilter
use Grails dispatcher-level override
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
