The GitHub Actions job "CI" on grails-core.git/fix/geb-login-form-race has 
failed.
Run started by GitHub user codeconsole (triggered by codeconsole).

Head commit for run:
509180fd7436b52a153108b8fe8a49d77b8e7b9b / Scott Murphy <[email protected]>
Fill the login form until the values stay filled

UserControllerSpec fails now and then with a thirty second wait for a login 
page that never
goes away. The report Geb writes at the failure shows why: the browser is on a 
login page whose
fields are empty, with the focus ring still on the first one where autofocus 
put it, and no
error - so the page was loaded after the credentials were typed, and nothing 
was ever submitted.
Both fields are required, so a form left empty is one the browser refuses to 
send. The wait then
has nothing to wait for.

The page is rendered because a protected page asked for it, and the document 
that was typed into
can be replaced by one that was still on its way. Filling it again until the 
values stay makes
the click work with what it needs, rather than assuming the typing landed on 
the document that
will be submitted.

Three page objects are reached that way and fill without checking: this one, 
and the two in the
misc functional test application, whose specifications also arrive by being 
redirected from a
secured page. Those two set the fields rather than appending to them now, since 
a second attempt
would otherwise double the text.

The ldap and acl applications fill without checking too and are left alone: 
they navigate to
their login page directly rather than being sent to it, and every call site 
follows the login
with an at-check, which waits. Nothing there has failed this way.

Report URL: https://github.com/apache/grails-core/actions/runs/32789589183

With regards,
GitHub Actions via GitBox

Reply via email to